fix: safely getting all the values for trigger tags #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyzhao2018
changed the title
nhulston
reviewed
May 13, 2025
nhulston
approved these changes
May 13, 2025
| @@ -114,10 +114,14 @@ def parse_event_source(event: dict) -> _EventSource: | |||
|
|
|||
| event_source = None | |||
|
|
|||
| request_context = event.get("requestContext") | |||
| # Get requestContext safely and ensure it's a dictionary | |||
| request_context = event.get("requestContext", {}) | |||
There was a problem hiding this comment.
it's better to do request_context = event.get("requestContext") or {} becuase it will avoid an allocation in the case that the key is found in the dict.
There was a problem hiding this comment.
that's some expert level advice on allocation, thanks!
| # Get requestContext safely and ensure it's a dictionary | ||
| request_context = event.get("requestContext", {}) | ||
| if not isinstance(request_context, dict): | ||
| request_context = {} |
There was a problem hiding this comment.
It would probably be better in this case to set request_context = None. This way we avoid the extra allocation and we don't even attempt any of the request_context.gets that happen after.
| # Safely get request_context and ensure it's a dictionary | ||
| request_context = event.get("requestContext", {}) | ||
| if not isinstance(request_context, dict): | ||
| request_context = {} |
There was a problem hiding this comment.
Same here. I think we can do this more efficiently.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make sure we get the
trigger_tagsvalues safely without raising exceptions. We have some customer's payload that cannot be properly handled currently.As an alternative, there's a
try-catch-callsolution. (Not recommended)The recommended approach is this PR.
Motivation
https://datadoghq.atlassian.net/browse/APMSVLS-10
Customer ticket:
https://datadoghq.atlassian.net/browse/SLES-2218
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply